fix(instrumentation-fs): fix fs.exists when it's util.promisified
#1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
==========================================
+ Coverage 96.08% 96.20% +0.12%
==========================================
Files 14 15 +1
Lines 893 948 +55
Branches 191 195 +4
==========================================
+ Hits 858 912 +54
- Misses 35 36 +1
|
vmarchaud
approved these changes
Oct 8, 2022
Flarna
approved these changes
Oct 10, 2022
| if (fName === 'exists') { | ||
| // handling separately because of the inconsistent cb style: | ||
| // `exists` doesn't have error as the first argument, but the result | ||
| if (isWrapped(fs[fName])) { |
There was a problem hiding this comment.
there is no need to duplicate this if. could be moved up before if (fName === 'exists') { once for all.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
fs.existshas an unusual signature with the callback never returning an error.To get around that when using
util.promisify, custom promisifing function is defined.Our instrumentation doesn't take that into account.
Fixes #1185
Short description of the changes
Added separate patcher for
fs.existsthat is aware of the above and define a new custom promisifying function for our patched function.